-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unstable UtilAllTest#testCalculateFileSizeInPath on Windows #7419
Fix unstable UtilAllTest#testCalculateFileSizeInPath on Windows #7419
Conversation
@lizhimins thanks for approving this!
Can this job be re-run? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## develop #7419 +/- ##
=============================================
+ Coverage 42.97% 43.05% +0.07%
- Complexity 9665 9683 +18
=============================================
Files 1161 1161
Lines 83920 83926 +6
Branches 10898 10899 +1
=============================================
+ Hits 36064 36131 +67
+ Misses 43379 43321 -58
+ Partials 4477 4474 -3
... and 30 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
This patch offers an alternative approach to 5d492c3. Instead of manually setting up the directory #testCalculateFileSizeInPath needs and then recursively deleting it, it uses JUnit's TemporaryFolder Rule to handle all of this work, and allows the code to concentrate on the business logic. Closes apache#7418
076e62b
to
f2936f9
Compare
I've rebased this PR on to of the current IMHO, this is a "cleaner" solution to the same problem, although #7445 already properly fixes it. Of course, if the maintainers disagree, I'll close it. |
@mureinik This pull request is good and shall be merged |
Which Issue(s) This PR Fixes
Fixes #7418
Brief Description
This MR offers an alternative approach to #7445 (5d492c3).
Instead of manually setting up the directory
testCalculateFileSizeInPath
needs and then recursively deleting it, it uses JUnit'sTemporaryFolder
@Rule
to handle all of this work, and allows the code to concentrate on the business logic.How Did You Test This Change?
Running
mvn install
passes now, as well as running this test manually from IntelliJ