Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #9025] [RIP-73] Modify Pop Consumption rocksdb init config #9100

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

lizhimins
Copy link
Member

Which Issue(s) This PR Fixes

Fixes #9025

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 6.25000% with 45 lines in your changes missing coverage. Please review.

Project coverage is 47.94%. Comparing base (f32fe78) to head (40bad59).

Files with missing lines Patch % Lines
.../rocketmq/store/rocksdb/RocksDBOptionsFactory.java 0.00% 45 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9100      +/-   ##
=============================================
- Coverage      48.10%   47.94%   -0.17%     
+ Complexity     12072    12037      -35     
=============================================
  Files           1320     1320              
  Lines          92782    92824      +42     
  Branches       11897    11897              
=============================================
- Hits           44636    44506     -130     
- Misses         42654    42807     +153     
- Partials        5492     5511      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lollipopjin lollipopjin merged commit a3afb05 into apache:develop Jan 3, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] [RIP‐73] Pop Consumption Improvement Based on RocksDB
3 participants