Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEDONA-680] Remove rasterio from mandatory dependencies #1692

Merged
merged 3 commits into from
Nov 23, 2024
Merged

Conversation

jiayuasu
Copy link
Member

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

This is to address several issues reported by users: #1688 #1574 #1607

  1. Move rasterio dependency to optional dependencies
  2. Add explanation in doc

How was this patch tested?

Passed local test

Did this PR include necessary documentation updates?

  • Yes, I have updated the documentation.

@jiayuasu jiayuasu added this to the sedona-1.7.0 milestone Nov 23, 2024
@jiayuasu jiayuasu linked an issue Nov 23, 2024 that may be closed by this pull request
@Kontinuation
Copy link
Member

Simply changing the dependency to optional may not be sufficient. sedona.sql.types imports raster_serde, which imports rasterio transitively.

I'll append new commits to this patch and run additional tests without rasterio installed on GitHub Actions.

@jiayuasu
Copy link
Member Author

@Kontinuation Agree. Forgot that part. We need to bypass that part too. Please go ahead and append commits.

@Kontinuation
Copy link
Member

@Kontinuation Agree. Forgot that part. We need to bypass that part too. Please go ahead and append commits.

Now it is working.

@jiayuasu jiayuasu merged commit b66e768 into master Nov 23, 2024
25 checks passed
@jiayuasu jiayuasu deleted the SEDONA-680 branch November 23, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

APache-sedona Failure
2 participants