Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEDONA-683] exclude some repetitive dependencies #1704

Merged
merged 1 commit into from
Nov 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,20 @@
<artifactId>cdm-core</artifactId>
<version>${cdm.version}</version>
<scope>${cdm.scope}</scope>
<exclusions>
<exclusion>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
</exclusion>
<exclusion>
<groupId>org.apache.httpcomponents</groupId>
<artifactId>httpclient</artifactId>
</exclusion>
<exclusion>
<groupId>com.google.protobuf</groupId>
<artifactId>protobuf-java</artifactId>
</exclusion>
Comment on lines +177 to +180
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: protobuf-java became shaded since Spark 3.5 (SPARK-41244). However, protobuf is only used for the experimental NetCDF streaming format so excluding it won't affect our NetCDF support.

</exclusions>
</dependency>
<!--The following GeoTools dependencies use GNU Lesser General Public License and thus are excluded from the binary distribution-->
<!-- Users have to include them by themselves manually -->
Expand Down
5 changes: 5 additions & 0 deletions spark-shaded/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,11 @@
<artifactSet>
<excludes>
<exclude>org.scala-lang:scala-library</exclude>
<exclude>org.apache.commons:commons-*</exclude>
<exclude>commons-pool:commons-pool</exclude>
<exclude>commons-lang:commons-lang</exclude>
<exclude>commons-io:commons-io</exclude>
<exclude>commons-logging:commons-logging</exclude>
</excludes>
</artifactSet>
<filters>
Expand Down
Loading