refactor container builder to common pkg #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlycore
approved these changes
Apr 11, 2023
|
LGTM |
moomman
added a commit
to moomman/shardingsphere-on-cloud
that referenced
this pull request
Apr 12, 2023
* refactor container builder to pkg/common * fix golang-lint check * add lincense check --------- Co-authored-by: moonman <agoiyanzsa@163.com>
mlycore
added a commit
that referenced
this pull request
Apr 13, 2023
* chore: add ifExists to ast (#304) Signed-off-by: wangbo <wangbo@sphere-ex.com> Co-authored-by: wangbo <wangbo@sphere-ex.com> * Common builder (#305) * refactor container builder to pkg/common * fix golang-lint check * add lincense check --------- Co-authored-by: moonman <agoiyanzsa@163.com> * refactor configmap to common pkg (#306) Co-authored-by: moonman <agoiyanzsa@163.com> * Rebase main --------- Signed-off-by: mlycore <maxwell92@126.com> Co-authored-by: Xu-Wentao <cutenear1993@yahoo.com> Co-authored-by: liyao <maxwell92@126.com> Co-authored-by: Zhengqiang Duan <duanzhengqiang@apache.org> Co-authored-by: moonman <agoiyanzsa@163.com> * chore: update go mod Signed-off-by: mlycore <maxwell92@126.com> --------- Signed-off-by: wangbo <wangbo@sphere-ex.com> Signed-off-by: mlycore <maxwell92@126.com> Co-authored-by: Jack <875818649@qq.com> Co-authored-by: wangbo <wangbo@sphere-ex.com> Co-authored-by: moonman <agoiyanzsa@163.com> Co-authored-by: Xu-Wentao <cutenear1993@yahoo.com> Co-authored-by: liyao <maxwell92@126.com> Co-authored-by: Zhengqiang Duan <duanzhengqiang@apache.org>
mlycore
added a commit
that referenced
this pull request
Apr 13, 2023
* bugfix(pitr): fix storage nodes info struct error, add endtime to backup file, and fix backup mode ptrack did not work. (#288) * chore(ci): add golangci-lint and refactor according to the result (#294) * chore: add golangci-lint check config and update Makefile for check * fix: fix according to golangci-lint * fix: rename Api to API * fix: fix sharedVolumeAndMountBuild SetVolumeMountSize non-zero slice * fix: remove overlapped Build method from shardingSphereProxyContainerBuilder * chore: add license header * chore(ci): add golangci-lint (#295) * chore(ci): add golangci-lint to github action Signed-off-by: mlycore <maxwell92@126.com> * chore(ci): seperate unit tests Signed-off-by: mlycore <maxwell92@126.com> * chore(ci): add golangci-lint for pitr Signed-off-by: mlycore <maxwell92@126.com> * chore(ci): fix license header Signed-off-by: mlycore <maxwell92@126.com> --------- Signed-off-by: mlycore <maxwell92@126.com> * refactor(operator): refactor according to golangci-lint (#296) * chore: seperate golangci-lint to base and advanced lints Signed-off-by: mlycore <maxwell92@126.com> * fix: introduce CondSucceed to Proxy and ComputeNode status Signed-off-by: mlycore <maxwell92@126.com> * chore: fix according to golangci-lint Signed-off-by: mlycore <maxwell92@126.com> * chore: refactor according to golangci-lint Signed-off-by: mlycore <maxwell92@126.com> * chore: update golangci-lint Signed-off-by: mlycore <maxwell92@126.com> * chore: remove loggercheck Signed-off-by: mlycore <maxwell92@126.com> * fix: fix unit test Signed-off-by: mlycore <maxwell92@126.com> * chore(ci): seperate golint to operator and pitr Signed-off-by: mlycore <maxwell92@126.com> * chore: add lint for commit message Signed-off-by: mlycore <maxwell92@126.com> --------- Signed-off-by: mlycore <maxwell92@126.com> * fix: fix proxy controller according to golangci-lint (#299) * chore: update golangci-lint Signed-off-by: mlycore <maxwell92@126.com> * chore: fix according to golangci-lint Signed-off-by: mlycore <maxwell92@126.com> * refactor: refactor update service with computenode Signed-off-by: mlycore <maxwell92@126.com> * fix: update service Signed-off-by: mlycore <maxwell92@126.com> * refactor: refactor proxy controller reconcile hpa, deployment and configmap according to golangci-lint Signed-off-by: mlycore <maxwell92@126.com> * chore: update commit-msg action Signed-off-by: mlycore <maxwell92@126.com> --------- Signed-off-by: mlycore <maxwell92@126.com> * chore: update varnamelen default to 1 Signed-off-by: mlycore <maxwell92@126.com> * fix: fix updateSSProxyContainer Signed-off-by: mlycore <maxwell92@126.com> * refactor: refactor getReadyProxyInstances Signed-off-by: mlycore <maxwell92@126.com> * refactor: refactor getReadyNodes Signed-off-by: mlycore <maxwell92@126.com> * fix: fix NewDeployment and set agent Signed-off-by: mlycore <maxwell92@126.com> * chore: update golangci-lint Signed-off-by: mlycore <maxwell92@126.com> * bugfix(pitr): fix test case show no record (#297) * test(pitr): fix test case show no record * style: lint code * feat: Implements EncryptionRule DistSQL Parser Visitor with AST (#301) * feat: implements encrypt rule distsql visitor interface with ast Signed-off-by: wangbo <wangbo@sphere-ex.com> * feat: add TODO Signed-off-by: wangbo <wangbo@sphere-ex.com> * chore: fix import package error Signed-off-by: wangbo <wangbo@sphere-ex.com> * chore: fix ci error Signed-off-by: wangbo <wangbo@sphere-ex.com> * chore: fix lint Signed-off-by: wangbo <wangbo@sphere-ex.com> * feat: add encrypt distsql ast Signed-off-by: wangbo <wangbo@sphere-ex.com> --------- Signed-off-by: wangbo <wangbo@sphere-ex.com> Co-authored-by: wangbo <wangbo@sphere-ex.com> * chore: add ifExists to ast (#304) Signed-off-by: wangbo <wangbo@sphere-ex.com> Co-authored-by: wangbo <wangbo@sphere-ex.com> * Common builder (#305) * refactor container builder to pkg/common * fix golang-lint check * add lincense check --------- Co-authored-by: moonman <agoiyanzsa@163.com> * refactor configmap to common pkg (#306) Co-authored-by: moonman <agoiyanzsa@163.com> --------- Signed-off-by: mlycore <maxwell92@126.com> Signed-off-by: wangbo <wangbo@sphere-ex.com> Co-authored-by: liyao <maxwell92@126.com> Co-authored-by: Zhengqiang Duan <duanzhengqiang@apache.org> Co-authored-by: Jack <875818649@qq.com> Co-authored-by: wangbo <wangbo@sphere-ex.com> Co-authored-by: moomman <85389467+moomman@users.noreply.github.com> Co-authored-by: moonman <agoiyanzsa@163.com>
Xu-Wentao
added a commit
to Xu-Wentao/shardingsphere-on-cloud
that referenced
this pull request
May 5, 2023
* bugfix(pitr): fix storage nodes info struct error, add endtime to backup file, and fix backup mode ptrack did not work. (apache#288) * chore(ci): add golangci-lint and refactor according to the result (apache#294) * chore: add golangci-lint check config and update Makefile for check * fix: fix according to golangci-lint * fix: rename Api to API * fix: fix sharedVolumeAndMountBuild SetVolumeMountSize non-zero slice * fix: remove overlapped Build method from shardingSphereProxyContainerBuilder * chore: add license header * chore(ci): add golangci-lint (apache#295) * chore(ci): add golangci-lint to github action Signed-off-by: mlycore <maxwell92@126.com> * chore(ci): seperate unit tests Signed-off-by: mlycore <maxwell92@126.com> * chore(ci): add golangci-lint for pitr Signed-off-by: mlycore <maxwell92@126.com> * chore(ci): fix license header Signed-off-by: mlycore <maxwell92@126.com> --------- Signed-off-by: mlycore <maxwell92@126.com> * refactor(operator): refactor according to golangci-lint (apache#296) * chore: seperate golangci-lint to base and advanced lints Signed-off-by: mlycore <maxwell92@126.com> * fix: introduce CondSucceed to Proxy and ComputeNode status Signed-off-by: mlycore <maxwell92@126.com> * chore: fix according to golangci-lint Signed-off-by: mlycore <maxwell92@126.com> * chore: refactor according to golangci-lint Signed-off-by: mlycore <maxwell92@126.com> * chore: update golangci-lint Signed-off-by: mlycore <maxwell92@126.com> * chore: remove loggercheck Signed-off-by: mlycore <maxwell92@126.com> * fix: fix unit test Signed-off-by: mlycore <maxwell92@126.com> * chore(ci): seperate golint to operator and pitr Signed-off-by: mlycore <maxwell92@126.com> * chore: add lint for commit message Signed-off-by: mlycore <maxwell92@126.com> --------- Signed-off-by: mlycore <maxwell92@126.com> * fix: fix proxy controller according to golangci-lint (apache#299) * chore: update golangci-lint Signed-off-by: mlycore <maxwell92@126.com> * chore: fix according to golangci-lint Signed-off-by: mlycore <maxwell92@126.com> * refactor: refactor update service with computenode Signed-off-by: mlycore <maxwell92@126.com> * fix: update service Signed-off-by: mlycore <maxwell92@126.com> * refactor: refactor proxy controller reconcile hpa, deployment and configmap according to golangci-lint Signed-off-by: mlycore <maxwell92@126.com> * chore: update commit-msg action Signed-off-by: mlycore <maxwell92@126.com> --------- Signed-off-by: mlycore <maxwell92@126.com> * chore: update varnamelen default to 1 Signed-off-by: mlycore <maxwell92@126.com> * fix: fix updateSSProxyContainer Signed-off-by: mlycore <maxwell92@126.com> * refactor: refactor getReadyProxyInstances Signed-off-by: mlycore <maxwell92@126.com> * refactor: refactor getReadyNodes Signed-off-by: mlycore <maxwell92@126.com> * fix: fix NewDeployment and set agent Signed-off-by: mlycore <maxwell92@126.com> * chore: update golangci-lint Signed-off-by: mlycore <maxwell92@126.com> * bugfix(pitr): fix test case show no record (apache#297) * test(pitr): fix test case show no record * style: lint code * feat: Implements EncryptionRule DistSQL Parser Visitor with AST (apache#301) * feat: implements encrypt rule distsql visitor interface with ast Signed-off-by: wangbo <wangbo@sphere-ex.com> * feat: add TODO Signed-off-by: wangbo <wangbo@sphere-ex.com> * chore: fix import package error Signed-off-by: wangbo <wangbo@sphere-ex.com> * chore: fix ci error Signed-off-by: wangbo <wangbo@sphere-ex.com> * chore: fix lint Signed-off-by: wangbo <wangbo@sphere-ex.com> * feat: add encrypt distsql ast Signed-off-by: wangbo <wangbo@sphere-ex.com> --------- Signed-off-by: wangbo <wangbo@sphere-ex.com> Co-authored-by: wangbo <wangbo@sphere-ex.com> * chore: add ifExists to ast (apache#304) Signed-off-by: wangbo <wangbo@sphere-ex.com> Co-authored-by: wangbo <wangbo@sphere-ex.com> * Common builder (apache#305) * refactor container builder to pkg/common * fix golang-lint check * add lincense check --------- Co-authored-by: moonman <agoiyanzsa@163.com> * refactor configmap to common pkg (apache#306) Co-authored-by: moonman <agoiyanzsa@163.com> --------- Signed-off-by: mlycore <maxwell92@126.com> Signed-off-by: wangbo <wangbo@sphere-ex.com> Co-authored-by: liyao <maxwell92@126.com> Co-authored-by: Zhengqiang Duan <duanzhengqiang@apache.org> Co-authored-by: Jack <875818649@qq.com> Co-authored-by: wangbo <wangbo@sphere-ex.com> Co-authored-by: moomman <85389467+moomman@users.noreply.github.com> Co-authored-by: moonman <agoiyanzsa@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change:
#272