Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(operator): fix status.result error #324

Merged
merged 7 commits into from
Apr 28, 2023
Merged

Conversation

moomman
Copy link
Contributor

@moomman moomman commented Apr 25, 2023

Type of change:

  • Bugfix

What this PR does / why we need it:

fix status.result log error

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?

#272

@mlycore mlycore added operator solutions of operator in: chaos modules of shardingsphere chaos labels Apr 25, 2023
@mlycore mlycore added this to the 0.3.0 milestone Apr 25, 2023
@mlycore mlycore changed the title feat-ssChaos: fix status.result error bug feat(operator): fix status.result error Apr 28, 2023
mlycore
mlycore previously approved these changes Apr 28, 2023
mlycore
mlycore previously approved these changes Apr 28, 2023
mlycore
mlycore previously approved these changes Apr 28, 2023
@sonarcloud
Copy link

sonarcloud bot commented Apr 28, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
5.5% 5.5% Duplication

@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2023

Codecov Report

Merging #324 (62fd385) into main (095d94c) will decrease coverage by 6.55%.
The diff coverage is 1.91%.

@@            Coverage Diff             @@
##             main     #324      +/-   ##
==========================================
- Coverage   45.99%   39.44%   -6.55%     
==========================================
  Files          20       44      +24     
  Lines        1698     4586    +2888     
==========================================
+ Hits          781     1809    +1028     
- Misses        832     2645    +1813     
- Partials       85      132      +47     
Impacted Files Coverage Δ
...ator/cmd/shardingsphere-operator/manager/option.go 51.68% <0.00%> (ø)
...perator/pkg/controllers/compute_node_controller.go 6.72% <0.00%> (ø)
...pkg/controllers/shardingsphere_chaos_controller.go 0.00% <0.00%> (ø)
...phere-operator/pkg/kubernetes/configmap/builder.go 52.85% <ø> (ø)
...e-operator/pkg/kubernetes/deployment/deployment.go 0.00% <0.00%> (ø)
...gsphere-operator/pkg/kubernetes/service/buidler.go 100.00% <ø> (ø)
...gsphere-operator/pkg/kubernetes/service/service.go 0.00% <0.00%> (ø)
...-operator/pkg/reconcile/shardingspherechaos/job.go 0.00% <0.00%> (ø)
...ere-operator/pkg/kubernetes/configmap/configmap.go 38.46% <36.36%> (ø)
...here-operator/pkg/kubernetes/deployment/builder.go 83.18% <100.00%> (ø)

... and 14 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mlycore mlycore merged commit 1712e57 into apache:main Apr 28, 2023
@moomman moomman deleted the fix-status branch April 29, 2023 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: chaos modules of shardingsphere chaos operator solutions of operator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants