Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(operator): change chaos deletion to finalizer rather than ownreference #337

Merged
merged 1 commit into from
May 5, 2023

Conversation

moomman
Copy link
Contributor

@moomman moomman commented May 5, 2023

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

Delete chaos resource by finalizer, remove ownreference.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?

#272

@codecov-commenter
Copy link

codecov-commenter commented May 5, 2023

Codecov Report

Merging #337 (2f3889c) into main (f7509f1) will decrease coverage by 6.29%.
The diff coverage is 6.66%.

@@            Coverage Diff             @@
##             main     #337      +/-   ##
==========================================
- Coverage   45.80%   39.51%   -6.29%     
==========================================
  Files          21       44      +23     
  Lines        1692     4694    +3002     
==========================================
+ Hits          775     1855    +1080     
- Misses        832     2712    +1880     
- Partials       85      127      +42     
Impacted Files Coverage Δ
...pkg/controllers/shardingsphere_chaos_controller.go 0.00% <0.00%> (ø)
...here-operator/pkg/kubernetes/deployment/builder.go 83.33% <50.00%> (ø)
...ere-operator/pkg/kubernetes/configmap/configmap.go 46.15% <100.00%> (ø)

... and 20 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@Xu-Wentao Xu-Wentao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sonarcloud
Copy link

sonarcloud bot commented May 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@moomman moomman changed the title change chaos deletion to finalizer rather than ownreference refactor(controller): change chaos deletion to finalizer rather than ownreference May 5, 2023
@moomman moomman changed the title refactor(controller): change chaos deletion to finalizer rather than ownreference refactor(operator): change chaos deletion to finalizer rather than ownreference May 5, 2023
@mlycore mlycore added this to the 0.3.0 milestone May 5, 2023
@mlycore mlycore added type: refactor operator solutions of operator in: chaos modules of shardingsphere chaos labels May 5, 2023
@mlycore mlycore merged commit ac6fab1 into apache:main May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: chaos modules of shardingsphere chaos operator solutions of operator type: refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants