Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: init will not return err if path exists #481

Merged
merged 1 commit into from
Dec 18, 2023
Merged

fix: init will not return err if path exists #481

merged 1 commit into from
Dec 18, 2023

Conversation

mlycore
Copy link
Contributor

@mlycore mlycore commented Dec 18, 2023 •
edited
Loading

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

It should skip the gs_probackup init if the backup path is existed.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?

@mlycore
fix: init will not return err if path exists
1a8e600 
Signed-off-by: mlycore <miaoliyao@apache.org>
@github-actions github-actions bot added the pitr solutions of pitr label Dec 18, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 18, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mlycore mlycore added this to the 0.4.0 milestone Dec 18, 2023
@strongduanmu strongduanmu merged commit 829f4b8 into apache:main Dec 18, 2023
7 checks passed
@mlycore mlycore deleted the fix-init-path branch December 18, 2023 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strongduanmu strongduanmu strongduanmu approved these changes

Assignees
No one assigned
Labels
pitr solutions of pitr type: fixed
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mlycore @strongduanmu