Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#31892 Refactor: Removed redundant indents from g4 files. #32779

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

Arshveer439
Copy link
Contributor

Fixes #31892.

Changes proposed in this pull request:
Removed redundant indents for empty lines in g4 files.

Copy link
Member

@linghengqian linghengqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Isn't this what happens when we format we code using ./mvnw spotless:apply -Pcheck? Why do you need to remove these spaces?
  • update: I just saw the original issue.

Copy link
Member

@linghengqian linghengqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@linghengqian linghengqian added this to the 5.5.1 milestone Sep 9, 2024
@linghengqian linghengqian merged commit 1a0804e into apache:master Sep 9, 2024
141 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[code conduct] There are a lot of indents in the g4 files that shouldn't be there
2 participants