Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design a longer wait time before executing INSERT SQL in nativeTest of Zookeeper and Etcd #32782

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

linghengqian
Copy link
Member

@linghengqian linghengqian commented Sep 3, 2024

Fixes https://github.com/apache/shardingsphere/actions/runs/10671433372/job/29577234822 .

Changes proposed in this pull request:

  • Design a longer wait time before executing INSERT SQL in nativeTest of Zookeeper and Etcd. Currently, the waiting time for these two unit tests is still too short, and the metadata is often not fully refreshed. Manually refreshing metadata involves a lot of Java APIs that are not documented at all.
  • I found that the DETELE statement of Clickhouse JDBC Driver sometimes takes a long time to execute. I think this is a bug in Clickhouse JDBC Driver, but the reproduction is not stable and can only be reproduced unstably in GraalVM Native Image.

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

},
{
"condition":{"typeReachable":"org.apache.shardingsphere.infra.util.eventbus.EventBusContext"},
"name":"org.apache.shardingsphere.mode.manager.cluster.event.subscriber.dispatch.StateChangedSubscriber",
"methods":[{"name":"renew","parameterTypes":["org.apache.shardingsphere.mode.event.dispatch.state.cluster.ClusterStateEvent"] }]
"allPublicMethods":true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • This is just a simplification; the only public methods on this class are obviously renew and its variants.

@FlyingZC FlyingZC merged commit 3ac3b54 into apache:master Sep 3, 2024
142 checks passed
@linghengqian linghengqian deleted the fix-native branch September 3, 2024 03:08
@linghengqian linghengqian added this to the 5.5.1 milestone Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants