Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provides nightly builds on ghcr.io for ShardingSphere Agent #32827

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

linghengqian
Copy link
Member

@linghengqian linghengqian commented Sep 10, 2024

For #32777.

Changes proposed in this pull request:

  • Provides nightly builds on ghcr.io for ShardingSphere Agent.

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@linghengqian linghengqian added the feature: agent shardingsphere agent label Sep 10, 2024
@linghengqian linghengqian marked this pull request as ready for review September 10, 2024 11:30
Copy link
Member Author

@linghengqian linghengqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jiangML I will say that I am not familiar with the ASF release process. Can we claim that shardingsphere agent on Docker Hub is not an official ASF artifact, as apache skywalking agent did? Then bypass the release process to release the Docker Image of the Agent on the Docker Hub? See https://hub.docker.com/r/apache/skywalking-java-agent .

@taojintianxia taojintianxia merged commit 9fd17d1 into apache:master Sep 18, 2024
12 checks passed
@linghengqian linghengqian deleted the agent branch September 18, 2024 04:06
@linghengqian linghengqian added this to the 5.5.1 milestone Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: agent shardingsphere agent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants