-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge dev_postgresql into the master branch #1115
Conversation
Add DeprecationWarning ignore message to the running script of cnn ex…
Add training scripts for xceptionnet
mlp model examples on top of postgresql
readme for malaria prediction with cnn model
add shell command file to run the codes
Init the model selection examples, and add README.md
Init armnet examples, add README.md
Add data loader for malaria dataset
add cnn model for malaria detection
add mlp model for malaria detection
Add the training file for model selection
Add SGD optimizer for model selection
Add implementation for a single optimization step in model selection
Increase the step counter, learning rate for the model selection SGD
Add get and set states
Add the training script for CNN models
Add the training script for models using MPI
Model class file for dynamic models
Add the ModelMeta for dynamic models
Update the ModelMeta class
Add the running script for model selection
Add the training script for model selection
Add data processing functions for model selection
Add the optimizer for model selection
Add the implementation of MSSGD for model selection
Add the implementation of a single optimization step for model selection
Add the implementation for the model selection example
Update license headers for v4.1.0
Add the release notes for v4.1.0
*************************************************************/ | ||
|
||
/* | ||
This file is auto generated by pgrx. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can remove this auto generated file from the code repo?
Since it's auo-generated, it's license is not clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe write a script to generate this file at runtime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this file can be removed
|
||
# Two-Phase Model Selection on PostgreSQL | ||
|
||
Examples inside this folder show how to select a well-performing model using SInga inside RDBMS, such as PostgreSQL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SInga ->SINGA
![python](https://img.shields.io/badge/python-3.8.3-blue) | ||
![singa](https://img.shields.io/badge/singa-3.1.0-orange) | ||
|
||
This folder contains our Singa implementation of [ARM-Net: Adaptive Relation Modeling Network for Structured Data](https://dl.acm.org/doi/10.1145/3448016.3457321). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The folder does not have the source code files..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this release, we will remove this part
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to exclude the binary files (png, pdf, etc.) in the java/pom.xml file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, will exclude the binary files and state the self-created binary files in the notice file
@@ -0,0 +1,54 @@ | |||
aiofiles==23.1.0 | |||
blessed==1.20.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for such kind of files that cannot contain comments, they should be excluded in the rat check
https://github.com/apache/singa/blob/master/java/pom.xml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
binary files, config files, and requirement.txt files can not include the license header
* under the License. | ||
* | ||
*************************************************************/ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this file auto-generated or from other project?
if auto-generated, can replace it with a script to generate the file?
if from other project, need to include the project's license in LICENSE file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these .rs files are written by us
|
||
=============================================================================== | ||
SINGA bundles the following under The PostgreSQL License: | ||
examples/model_selection/TRAILS-Database-Native-Model-Selection/internal/pg_extension/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the same set of files are under MIT and PostgreSQL?
if these are written by SINGA contributor (i.e., not copied from other projects), they should just be released under apache license.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these source files are written by us, so they should be released under apache license
Merge dev_postgresql into the master branch