Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STORM-4142 Log when falling back to java serialization #3824

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

MaheshAravindV
Copy link
Contributor

What is the purpose of the change

Falling back to java serialization should be a last resort and devs should have some warning when this happens.

How was the change tested

Not sure if tests are needed for log change. Can add if required.

@MaheshAravindV
Copy link
Contributor Author

Also, I am using storm version 2.3.0. Should I raise separate PR with base branch as 2.3.x for me to use these changes?

@MaheshAravindV
Copy link
Contributor Author

11:58:39.239 [Thread-39-1-executor[1, 1]] WARN  o.a.s.s.DefaultKryoFactory - Class is not registered: org.example.TestClass

@rzo1
Copy link
Contributor

rzo1 commented Jan 1, 2025

@MaheshAravindV Thanks for the PR. You do not need to do a backport - we are not planning to do any official releases from the 2.3.x series. If you need it, you can have a look at the GH actions building the nightlies and build a custom 2.3.x distribution with your patch.

@reiabreu reiabreu merged commit 1ccd04d into apache:master Jan 2, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants