Skip to content
This repository has been archived by the owner on Jul 10, 2024. It is now read-only.

SUBMARINE-1393. Add an Arm64 image for the notebook controller #1090

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pingsutw
Copy link
Member

What is this PR for?

Add an arm64 image for the notebook controller to run Submarine on an arm machine

What type of PR is it?

[mprovement]

Todos

NA

What is the Jira issue?

https://issues.apache.org/jira/browse/SUBMARINE-1393

How should this be tested?

NA

Screenshots (if appropriate)

Questions:

  • Do the license files need updating? No
  • Are there breaking changes for older versions? No
  • Does this need new documentation? No

@pingsutw pingsutw requested a review from cdmikechen July 20, 2023 13:16
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #1090 (440c6db) into master (4ddba98) will decrease coverage by 18.98%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #1090       +/-   ##
===========================================
- Coverage   66.83%   47.86%   -18.98%     
===========================================
  Files         130      130               
  Lines        6320     6320               
===========================================
- Hits         4224     3025     -1199     
- Misses       2096     3295     +1199     
Flag Coverage Δ
python-integration ?
python-unit 47.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 34 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pingsutw pingsutw marked this pull request as draft July 20, 2023 15:52
Signed-off-by: Kevin Su <pingsutw@apache.org>
@pingsutw
Copy link
Member Author

kubeflow/kubeflow#7220

Signed-off-by: Kevin Su <pingsutw@apache.org>
@cdmikechen
Copy link
Contributor

@pingsutw
Hi~ At present, the PR is still draft, and many CI tests fail. Do we need to fix all the failed workflows first?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants