refactor(Menu): Upgrade Menu Component to Ant Design 5 (#31699)

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
apache · Jan 21, 2025 · eec3744 · eec3744
1 parent 5501238
commit eec3744
Show file tree

Hide file tree

Showing 54 changed files with 984 additions and 1,379 deletions.
diff --git a/superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts b/superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts
@@ -56,15 +56,21 @@ const drillBy = (targetDrillByColumn: string, isLegacy = false) => {
 
   cy.get('.ant-dropdown:not(.ant-dropdown-hidden)')
     .first()
-    .find("[role='menu'] [role='menuitem'] [title='Drill by']")
+    .should('be.visible')
+    .find("[role='menu'] [role='menuitem']")
+    .contains(/^Drill by$/)
     .trigger('mouseover', { force: true });
+
   cy.get(
-    '.ant-dropdown-menu-submenu:not(.ant-dropdown-menu-hidden) [data-test="drill-by-submenu"]',
+    '.ant-dropdown-menu-submenu:not(.ant-dropdown-menu-submenu-hidden) [data-test="drill-by-submenu"]',
   )
+    .should('be.visible')
     .find('[role="menuitem"]')
-    .contains(new RegExp(`^${targetDrillByColumn}$`))
-    .first()
-    .click({ force: true });
+    .then($el => {
+      cy.wrap($el)
+        .contains(new RegExp(`^${targetDrillByColumn}$`))
+        .trigger('keydown', { keyCode: 13, which: 13, force: true });
+    });
 
   if (isLegacy) {
     return cy.wait('@legacyData');