Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SqlLab): improved database, schema, and table selection UI #31591

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

justinpark
Copy link
Member

SUMMARY

As purposed in SIP-111, this commit introduces the new SQL Lab sidebar UI using tree view structure.

  1. The database selector will be maintained, while the schema selector will be moved to a tree view.
  2. Change the dropdown UI for the table selector to a tree view for improved navigation.
  3. For databases that support catalogs, the catalog selector will be displayed under the database selector, and the tree will show the list of schemas for the corresponding category.
  4. Add a search box to allow users to find matches in both the datasource catalog and table metadata and schema for enhanced information retrieval.
  5. Caching and Action Buttons: As proposed, it will include a force-refresh feature and modify the existing functionalities from the previous table/schema to be displayed under the dropdown action link

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

sip-111--table-explore-tree.mov

TESTING INSTRUCTIONS

Go to SQL Lab and try to explore the table metadata using new UI

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

korbit-ai bot commented Dec 20, 2024

Korbit doesn't automatically review large (500+ lines changed) pull requests such as this one. If you want me to review anyway, use /korbit-review.

@dosubot dosubot bot added change:frontend Requires changing the frontend sqllab Namespace | Anything related to the SQL Lab labels Dec 20, 2024
@andy1xx8
Copy link

This UI is taking a lot of space vertically in the right panel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change:frontend Requires changing the frontend size/XXL sqllab Namespace | Anything related to the SQL Lab
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants