TINKERPOP-3096: improvement: add necessary parameters for logging to fix '%!x(MISSING)' output issue in gremlin-go #2684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: thomas-dg <dyhshome@126.com>
|
VOTE +1, thanks for fixing the bug! |
|
Given this is a small change, I'll be merging this as CTR after the actions pass. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.7-dev #2684 +/- ##
=============================================
+ Coverage 76.14% 80.44% +4.29%
=============================================
Files 1084 27 -1057
Lines 65160 4985 -60175
Branches 7285 0 -7285
=============================================
- Hits 49616 4010 -45606
+ Misses 12839 773 -12066
+ Partials 2705 202 -2503 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TINKERPOP-3096
I encountered a log message missing necessary parameters while using the 'Containing' function. The detailed log information is as follows:
2024/07/14 16:27:28 Error occurred during operation gremlinServerWSProtocol.readLoop(): 'E0703: expected string Key for map, got type='0x%!x(MISSING)''
2024/07/14 16:27:28 Read loop error 'E0703: expected string Key for map, got type='0x%!x(MISSING)'', closing read loop.
2024/07/14 16:27:28 Connection error callback invoked, closing protocol.