Bytecode removal in gremlin-python #2702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkagamlyk
reviewed
Aug 1, 2024
gremlin-python/src/main/python/gremlin_python/driver/driver_remote_connection.py
Show resolved
Hide resolved
vkagamlyk
reviewed
Aug 1, 2024
gremlin-python/src/main/python/gremlin_python/driver/driver_remote_connection.py
Outdated
Show resolved
Hide resolved
vkagamlyk
reviewed
Aug 1, 2024
gremlin-python/src/main/python/gremlin_python/driver/request.py
Outdated
Show resolved
Hide resolved
vkagamlyk
requested changes
Aug 1, 2024
xiazcy
force-pushed
the
python-remove-bytecode
branch
from
7510387 to
c4c2367
Compare
Cole-Greer
reviewed
Aug 2, 2024
xiazcy
force-pushed
the
python-remove-bytecode
branch
from
c4c2367 to
54713b2
Compare
vkagamlyk
approved these changes
Aug 8, 2024
|
python GLV build is broken, but it seems not because of changes in this PR, the same problem is in other branches. VOTE+1 |
|
VOTE +1 |
|
Thank you for all the reviews! VOTE +1 |
xiazcy
added a commit
that referenced
this pull request
Aug 28, 2024
removed bytecode in gremlin-python, and replaced with gremlin lang scripts
kenhuuu
pushed a commit
that referenced
this pull request
Nov 2, 2024
removed bytecode in gremlin-python, and replaced with gremlin lang scripts
kenhuuu
pushed a commit
that referenced
this pull request
Nov 3, 2024
removed bytecode in gremlin-python, and replaced with gremlin lang scripts
kenhuuu
pushed a commit
that referenced
this pull request
Nov 3, 2024
removed bytecode in gremlin-python, and replaced with gremlin lang scripts
kenhuuu
pushed a commit
that referenced
this pull request
Nov 3, 2024
removed bytecode in gremlin-python, and replaced with gremlin lang scripts
kenhuuu
pushed a commit
that referenced
this pull request
Nov 3, 2024
removed bytecode in gremlin-python, and replaced with gremlin lang scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced bytecode with gremlin lang scripts in gremlin-python, similar to what's been implemented in gremlin-java.
Groovy translators are no longer needed, as well as some other code left over from WebSocket; will be cleaning them up along with bytecode codes in a separate PR after this is merged.
Some TODOs are pending core changes, e.g. bulking, transactions.
Local unit and integration tests pass, next step is to implement authentication interface, and modifying docker-compose set up to enable tests during build/GitHub actions.
Also added set in gremlin-java gremlin lang as set is now supported in grammar (can separate that into different PR/CTR if preferred).Will open set changes for gremlin-java in separate PR due to additional changes needed.