Simplify Address#getInfo() native implementation #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-o
referenced
this pull request
May 26, 2021
Don't apply tricks and rely on OS behavior to resolve addresses. It is the caller's responsibility to properly process socket addresses if more than one exists. This mimics the behavior of HTTPd's listen.c for apr_sockaddr_info_get().
Don't apply tricks and rely on OS behavior to resolve addresses. This also aligns with the NIO implementatin using `InetSocketAddress`. This mimics the behavior of HTTPd's listen.c for apr_sockaddr_info_get().
|
This changes behaviour so it would need to wait until 1.3 (if there ever is such a version). |
For a transition phase, I would favor to remove everything in 1.3 which isn't used by Tomcat at all. In 2.0 remove APR. 1.3 can contain cleanups like this. OR do 2.0 and then 3.0 which support OpenSSL 1.1.1 and 3.0.0. |
|
@mturk You still owe me an explanation what will break for you. |
|
@mturk Still waiting... |
1 similar comment
|
@mturk Still waiting... |
|
@mturk still waiting... |
|
@mturk still waiting for years... |
indiff
approved these changes
Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't apply tricks and rely on OS behavior to resolve addresses. This also
aligns with the NIO implementatin using
InetSocketAddress.This mimics the behavior of HTTPd's listen.c for apr_sockaddr_info_get().
@mturk Let's discuss. I'd like to understand what will break in your deployments.