Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XALANJ-2618 Invalid encodings in Encodings.properties #167

Closed
wants to merge 1 commit into from
Closed

XALANJ-2618 Invalid encodings in Encodings.properties #167

wants to merge 1 commit into from

Conversation

cdamioli
Copy link

@cdamioli cdamioli commented Jan 25, 2024

Encodings.properties contains invalig encodings.
Since Java 9+ it causes issues while serializing ISO-8859-1 characters

See https://issues.apache.org/jira/browse/XALANJ-2618 and https://issues.apache.org/jira/browse/XALANJ-2625

@jkesselm jkesselm self-assigned this Jan 27, 2024
@jkesselm
Copy link
Contributor

We both have solutions (mine is at https://github.com/apache/xalan-java/tree/XALANJ-2618), I think I like my fix a bit better, since it resolves the problem without having to remove encoding names that, correct or not, someone might have been depending upon, and addresses the problem at a systemic level rather than just patching this one encoding set.

Any suggestions on the best way to make sure you get credit for isolating the issue while we check in my fix?

(I'm used to working in an environment where we cared more about the fix getting in than exactly who got credit for it, so my reflexes are not entirely right for public Git. I'm trying to retrain myself to be more sensitive about that, recognizing that contributor history is important for most folks.)

@jkesselm jkesselm closed this Feb 2, 2024
@cdamioli cdamioli deleted the XALANJ_2618 branch February 2, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants