fix: recreate pod without containers ready condition (#8591)

apecloud · Dec 5, 2024 · 2073ae0 · 2073ae0
1 parent a113ac9
commit 2073ae0
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/pkg/controller/instanceset/reconciler_update.go b/pkg/controller/instanceset/reconciler_update.go
@@ -130,7 +130,8 @@ func (r *updateReconciler) Reconcile(tree *kubebuilderx.ObjectTree) (kubebuilder
 		if updatedPods >= partition {
 			break
 		}
-		if !isContainersReady(pod) {
+		// when PodUpdatePolicy is Recreate, no need to check whether containers are ready.
+		if its.Spec.PodUpdatePolicy != workloads.RecreatePodUpdatePolicyType && !isContainersReady(pod) {
 			tree.Logger.Info(fmt.Sprintf("InstanceSet %s/%s blocks on update as some the container(s) of pod %s are not ready", its.Namespace, its.Name, pod.Name))
 			// as no further event triggers the next reconciliation, we need a retry
 			needRetry = true