Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Apache 2.2 support #203

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Remove Apache 2.2 support #203

wants to merge 1 commit into from

Conversation

dhawes
Copy link
Contributor

@dhawes dhawes commented Apr 4, 2022

No description provided.

@dhawes dhawes mentioned this pull request Apr 4, 2022
Merged
@dhawes dhawes force-pushed the apache-2.2-remove branch from efe6335 to 90bedfd Compare April 4, 2022 13:31
@mmuehlenhoff
Copy link
Contributor

Patch looks good to me (and I've also smoketested a build in our test environment)

@dhawes
Copy link
Contributor Author

dhawes commented Apr 13, 2022

TODO:

  • Fix tests that may be affected. I started a pass on this, but there are so many original tests that fail that I'm not sure if it's worth the time right now. I'll likely take this as a separate task.
  • Detect the Apache version in the configure step to give a nicer error message if using Apache 2.2.

@mmuehlenhoff
Copy link
Contributor

Agreed on postponing a rework of the tests for now.

As for the configure script, the following should so the trick, feel free to squash it into your PR: mmuehlenhoff@196f0e9

@dhawes
Copy link
Contributor Author

dhawes commented Apr 14, 2022

That doesn't seem to work with 2.2 apxs (doesn't like -v and the query parameter).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhawes @mmuehlenhoff