Removed warnings

apexcharts · Aug 27, 2023 · 22956d0 · 22956d0
1 parent 2140128
commit 22956d0
Show file tree

Hide file tree

Showing 8 changed files with 314 additions and 142 deletions.
diff --git a/docs/BlazorApexCharts.Docs/Components/Features/Annotations/Basic.razor b/docs/BlazorApexCharts.Docs/Components/Features/Annotations/Basic.razor
@@ -37,7 +37,8 @@
                                 Style = new Style{ Background="red" }
                            },
                            X = 40,
-                           BorderWidth = 3,
+                    //       BorderWidth = 3,
+                           
                            StrokeDashArray = 2,
                            BorderColor = "red"
                         }
@@ -50,7 +51,7 @@
                                 Style = new Style { Background = "blue", Color="white"}
                             },
                             Y = 70000,
-                            BorderWidth = 3,
+                           // BorderWidth = 3,
                             BorderColor = "blue",
                             StrokeDashArray = 0
                         }

diff --git a/docs/BlazorApexCharts.Docs/Components/Methods/Annotations/Basic.razor b/docs/BlazorApexCharts.Docs/Components/Methods/Annotations/Basic.razor
@@ -66,7 +66,8 @@
             {
                 X = "Sweden",
                 StrokeDashArray = 10,
-                BorderWidth = 2,
+                BorderWidth = 10,
+
                 Label = new Label
                 {
                     Text = "X Axis Annotation"

diff --git a/src/Blazor-ApexCharts/Blazor-ApexCharts.xml b/src/Blazor-ApexCharts/Blazor-ApexCharts.xml
diff --git a/src/Blazor-ApexCharts/Models/ApexChartOptions.cs b/src/Blazor-ApexCharts/Models/ApexChartOptions.cs
@@ -694,8 +694,7 @@ public class AnnotationsXAxis
 		/// </summary>
 		public string BorderColor { get; set; }
 
-#pragma warning disable CS1591 // Documentation not available for obsolete properties
-		[Obsolete("This property is no longer available")]
+#pragma warning disable CS1591 // Documentation not available but property is valid
 		public double? BorderWidth { get; set; }
 #pragma warning restore CS1591
 

diff --git a/src/Blazor-ApexCharts/Models/Converters/CustomJsonStringEnumConverter.cs b/src/Blazor-ApexCharts/Models/Converters/CustomJsonStringEnumConverter.cs
@@ -14,15 +14,15 @@ namespace ApexCharts.Models
     /// <remarks>
     /// <see href="https://stackoverflow.com/questions/59059989/system-text-json-how-do-i-specify-a-custom-name-for-an-enum-value">Stackoverflow Discussion</see>
     /// </remarks>
-    public class CustomJsonStringEnumConverter : JsonConverterFactory
+    internal class CustomJsonStringEnumConverter : JsonConverterFactory
     {
         private readonly JsonNamingPolicy namingPolicy;
         private readonly bool allowIntegerValues;
         private readonly JsonStringEnumConverter baseConverter;
 
-        public CustomJsonStringEnumConverter() : this(null, true) { }
+        internal CustomJsonStringEnumConverter() : this(null, true) { }
 
-        public CustomJsonStringEnumConverter(JsonNamingPolicy namingPolicy = null, bool allowIntegerValues = true)
+        internal CustomJsonStringEnumConverter(JsonNamingPolicy namingPolicy = null, bool allowIntegerValues = true)
         {
             this.namingPolicy = namingPolicy;
             this.allowIntegerValues = allowIntegerValues;
@@ -53,11 +53,11 @@ public override JsonConverter CreateConverter(Type typeToConvert, JsonSerializer
         }
     }
 
-    public class JsonNamingPolicyDecorator : JsonNamingPolicy
+    internal class JsonNamingPolicyDecorator : JsonNamingPolicy
     {
         readonly JsonNamingPolicy underlyingNamingPolicy;
 
-        public JsonNamingPolicyDecorator(JsonNamingPolicy underlyingNamingPolicy) => this.underlyingNamingPolicy = underlyingNamingPolicy;
+        internal JsonNamingPolicyDecorator(JsonNamingPolicy underlyingNamingPolicy) => this.underlyingNamingPolicy = underlyingNamingPolicy;
 
         /// <inheritdoc/>
         public override string ConvertName(string name) => underlyingNamingPolicy == null ? name : underlyingNamingPolicy.ConvertName(name);

diff --git a/src/Blazor-ApexCharts/Models/DataPoints/JSDataPointSelection.cs b/src/Blazor-ApexCharts/Models/DataPoints/JSDataPointSelection.cs
@@ -6,7 +6,10 @@ namespace ApexCharts
     /// Return data from JavaScript when a data point event occurs
     /// </summary>
     public class JSDataPointSelection
-    {
+    {
+        /// <summary>
+        /// List of selected DataPoints
+        /// </summary>
         public List<List<int?>> SelectedDataPoints { get; set; }
 
         /// <summary>
@@ -119,6 +122,9 @@ public class ZoomedData<TItem> where TItem : class
         /// <inheritdoc cref="SelectionXAxis"/>
         public SelectionXAxis XAxis { get; set; }
 
+        /// <summary>
+        /// Y Axis objects
+        /// </summary>
         public List<object> YAxis { get; set; }
 
         /// <summary>

diff --git a/src/Blazor-ApexCharts/Series/IApexSeries.cs b/src/Blazor-ApexCharts/Series/IApexSeries.cs
@@ -34,6 +34,10 @@ public interface IApexSeries<TItem> : IDisposable where TItem : class
         /// The color to assign to values in the data series
         /// </summary>
         string Color { get; set; }
+
+        /// <summary>
+        /// The name of the group
+        /// </summary>
         string Group { get; set; }
 
         /// <inheritdoc cref="DataLabels.Enabled"/>

diff --git a/src/Blazor-ApexCharts/Series/JSZoomed.cs b/src/Blazor-ApexCharts/Series/JSZoomed.cs
@@ -10,6 +10,10 @@ public class JSZoomed
         /// <inheritdoc cref="SelectionXAxis"/>
         public SelectionXAxis XAxis { get; set; }
 
+
+        /// <summary>
+        /// Y axis object
+        /// </summary>
         public List<object> YAxis { get; set; }
     }
 }