Fix: Switch default to_koalas in HiveData._read_table. to False
#42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
to_koalasargument has been deprecated in_read_tablesince it wasn't used. Returning koalas DataFrame during this step allows for more predictable behavior and fewer worries due to OOM errors.When
to_koalasis set to True, we raise a warning to indicate that this argument is not used. Since this argument is True by default, we raise this warning for every table to be read, which is unpleasant for the user.Therefore, this PR suggests setting
to_koalasto False by default.Checklist