fix: use stateOptions when retrieving a Parameter filter #6728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinceAmstoutz
force-pushed
the
fix-query-parameter-on-dto-with-state-options
branch
2 times, most recently
from
a2c48a9
to
11cc1e5
Compare
vinceAmstoutz
force-pushed
the
fix-query-parameter-on-dto-with-state-options
branch
from
11cc1e5
to
0affd52
Compare
Replaced state options logic in `ParameterResourceMetadataCollectionFactory` with a new method `getClassFromStateOptions`. This simplifies the code by centralizing the logic in the `Metadata` class and improves readability.
vinceAmstoutz
force-pushed
the
fix-query-parameter-on-dto-with-state-options
branch
from
7f2128d
to
55f4c94
Compare
vinceAmstoutz
force-pushed
the
fix-query-parameter-on-dto-with-state-options
branch
from
1fedd26
to
1fd61cb
Compare
soyuka
force-pushed
the
fix-query-parameter-on-dto-with-state-options
branch
from
20f4b70
to
c605174
Compare
soyuka
changed the title
soyuka
changed the title
soyuka
force-pushed
the
fix-query-parameter-on-dto-with-state-options
branch
from
c605174
to
fe4bce4
Compare
soyuka
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.4As mentioned in #6682, QueryParamter on DTO with
stateOptionsdoesn't work. This PR will solve this problem by applyingstateOptionsto theParameterResourceMetadataCollectionFactory.