Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy RRP contracts to new market chains #2000

Merged
merged 7 commits into from
Jun 28, 2024
Merged

Deploy RRP contracts to new market chains #2000

merged 7 commits into from
Jun 28, 2024

Conversation

vanshwassan
Copy link
Contributor

@vanshwassan vanshwassan commented Jun 9, 2024 •
edited
Loading

Deployed RRP contracts to the new chains that recently got added to the Market. Deterministic deployment worked for all the chains.

@vanshwassan vanshwassan requested a review from Ashar2shahid June 9, 2024 22:28
dcroote
dcroote reviewed Jun 11, 2024
View reviewed changes
Copy link
Contributor

@dcroote dcroote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any thoughts on why x-layer and x-layer-sepolia-testnet fail verification?

@vanshwassan
Copy link
Contributor Author

Any thoughts on why x-layer and x-layer-sepolia-testnet fail verification?

It's probably because the transactionHash and receipt are missing from the json files generated after the deployment. I remember this happening when I deployed the protocol contracts on arbitrum-sepolia in the past too. Will try to look into it but for now, I will just generate and add the fields manually.

@Ashar2shahid
Copy link
Contributor

I reran the tests all the new chains are passing tests, Ill update api3/chains to change the providers for the old chains that keep failing CI, (gnosis/polygon/ethereum-sepolia)

dcroote
dcroote approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@dcroote dcroote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reran the tests all the new chains are passing tests, Ill update api3/chains to change the providers for the old chains that keep failing CI, (gnosis/polygon/ethereum-sepolia)

Nice, makes sense

@Ashar2shahid Ashar2shahid merged commit c1fb30b into master Jun 28, 2024
28 of 29 checks passed
@Ashar2shahid Ashar2shahid deleted the deploy-rrp branch June 28, 2024 15:35
@bbenligiray bbenligiray mentioned this pull request Aug 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ashar2shahid Ashar2shahid Ashar2shahid approved these changes

@dcroote dcroote dcroote approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vanshwassan @Ashar2shahid @dcroote