Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix env variable names #47

Merged
merged 3 commits into from
Jul 6, 2023
Merged

Fix env variable names #47

merged 3 commits into from
Jul 6, 2023

Conversation

bbenligiray
Copy link
Member

Closes #46

@bbenligiray bbenligiray self-assigned this Jul 6, 2023
andreogle
andreogle approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@andreogle andreogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and seems to work as expected. Thanks

src/utils/strings.test.ts
@@ -13,12 +13,17 @@ describe('toUpperSnakeCase', () => {
assert.equal(result, 'HELLO_WORLD_4');
});

test('trims leading and trailing whtestespaces', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅

@bbenligiray bbenligiray merged commit 3295f43 into main Jul 6, 2023
3 checks passed
@bbenligiray bbenligiray deleted the fix-env-variable-names branch July 6, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreogle andreogle andreogle approved these changes

Assignees

@bbenligiray bbenligiray

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ugly environment variable names
2 participants
@bbenligiray @andreogle