Remove watch chains script #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreogle
commented
Aug 25, 2023
| } | ||
| }, | ||
| "browserUrl": "https://basescan.org/" | ||
| "name": "Base", |
There was a problem hiding this comment.
Prettier made these consistent with the other chain files - 2 spaces instead of 4 (the only acceptable number of spaces 😛)
package.json
Outdated
| "lint": "yarn lint:eslint && yarn lint:prettier && yarn lint:tsc", | ||
| "lint:eslint": "eslint . --ext .js,.ts", | ||
| "lint:prettier": "prettier --check \"./**/*.{js,md,json}\"", | ||
| "lint:tsc": "tsc --noEmit", |
There was a problem hiding this comment.
Not sure if this is necessary or not, since CI now also runs yarn build 🤷🏻♂️
dcroote
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
yarn devscript which provided the option of watching thechains/directory and immediately regenerated thechains.tsfile. This script is unnecessary and can be dropped in favour of a single development flow for now. Discussion: Fix generate-chains script to work with Prettier v3 #67chokidaras a devDependency (used for watching files)yarn lintscript to include runningprettier --checkandtsc --noEmit. I re-ran Prettier as part of this PR and noticed that some of the new chain JSON files weren't formatted. The developer will now be forced to runyarn prettierbefore pushing new changes..tsfiles. I completely missed this 🤦🏻♂️