-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contributing #544
Contributing #544
Conversation
Visit the preview URL for this PR (updated for commit 4090d6a): https://vitepress-docs--pr544-contributing-gmkcdhhb.web.app (expires Thu, 20 Jul 2023 08:18:24 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: e4c5db1acb62b36273dc03718b86834917dea599 |
You have some heading tags that do not make sense.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice start- I have several questions and suggestions.
Please also spell check both documents, there are a number of typos.
@wkande - once updated and ready, this PR will need to be squash merged because of the git history
Co-authored-by: Derek Croote <dcroote@users.noreply.github.com>
Co-authored-by: Derek Croote <dcroote@users.noreply.github.com>
Co-authored-by: Derek Croote <dcroote@users.noreply.github.com>
Co-authored-by: Derek Croote <dcroote@users.noreply.github.com>
Co-authored-by: Derek Croote <dcroote@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, only minor changes left
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
404s need to be fixed, then I think it will be good to go
how to clone, setup, and run the project locally. For non-DAO members a PR from | ||
a fork is always welcome. | ||
|
||
You can also see the [Contributing](/docs/explore/introduction/contributing.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
404 currently.
You can also see the [Contributing](/docs/explore/introduction/contributing.md) | |
You can also see the [Contributing](contributing.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use: /explore/introduction/contributing.md
### If you are learning about blockchain & oracles | ||
|
||
- Read the | ||
[getting started<ExternalLinkImage/>](docs/explore/introduction/index.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
404 currently.
[getting started<ExternalLinkImage/>](docs/explore/introduction/index.md) | |
[getting started<ExternalLinkImage/>](index.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use: /explore/introduction/index.md
See: https://docs.api3.org/dev/hyperlinks.html
Also I think the <ExternalLinkImage/>
component needs to go.
I will merge this then pull and fix the links and re-build the indexes. |
Thanks @wkande |
Introduction of a 'feedback to API3 docs' page
Review and build of 'contribute to API3 DAO' section