Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken links, language, capitalization #597

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Conversation

dcroote
Copy link
Collaborator

@dcroote dcroote commented Aug 14, 2023

An issue was that the page /guides/dapis/read-self-funded-dapi/ got renamed to /guides/dapis/read-a-dapi/ in #554 without that change being propagated through the various site pages. Other changes are minor like consistent capitalization, a few spelling errors, and .md links instead of .html.

@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit aa11596):

https://vitepress-docs--pr597-dcroote-dapis-cleanu-zcaf7inj.web.app

(expires Mon, 21 Aug 2023 06:33:09 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e4c5db1acb62b36273dc03718b86834917dea599

Copy link
Member

@wkande wkande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catches.

@wkande
Copy link
Member

wkande commented Aug 14, 2023

I will also run the linkValidator today just to be sure.

@wkande wkande merged commit e7a8fae into main Aug 14, 2023
2 checks passed
@wkande wkande deleted the dcroote/dapis-cleanup branch August 14, 2023 10:38
@wkande
Copy link
Member

wkande commented Aug 14, 2023

Will be creating a new PR as there are more broken links from the newly added pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants