Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add packageManager field to package.json #806

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Add packageManager field to package.json #806

merged 1 commit into from
Aug 23, 2024

Conversation

dcroote
Copy link
Collaborator

@dcroote dcroote commented Aug 23, 2024

@dcroote dcroote requested a review from wkande August 23, 2024 01:50
@dcroote dcroote self-assigned this Aug 23, 2024
Copy link
Contributor

Visit the preview URL for this PR (updated for commit e3acfda):

https://vitepress-docs--pr806-packagemanager-be039gsq.web.app

(expires Fri, 30 Aug 2024 01:51:36 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e4c5db1acb62b36273dc03718b86834917dea599

Copy link
Member

@wkande wkande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Do we need to document this is /dev. Mostly the Firebase changes. Was not sure if Firbase might need to be updated again in the future.

@dcroote
Copy link
Collaborator Author

dcroote commented Aug 23, 2024

Nope, this just simplifies pnpm within the Action workflows. Basically, we don't need to specify version 9 of pnpm within Actions workflow steps because pnpm looks for the version in package.json

@dcroote dcroote merged commit 686b949 into main Aug 23, 2024
2 checks passed
@dcroote dcroote deleted the packagemanager branch August 23, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants