Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: esm builds #323

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix: esm builds #323

wants to merge 1 commit into from

Conversation

ryanleecode
Copy link

@fnesveda fnesveda added the t-tooling Issues with this label are in the ownership of the tooling team. label Sep 4, 2024
@B4nan
Copy link
Member

B4nan commented Sep 4, 2024

Thanks for the PR, but we won't be merging this one, definitely not in such shape. If we are to change the monorepo setup, we will handle it ourselves, we are not interested in a complete rewrite like this. Also I hope you don't expect us to merge a PR that is doing so many things at once, including changing package manager, and doing many breaking changes like changing the TS configs completely.

I will leave it open, as I feel like parts of it might be usable at least as an inspiration.

Note that we are considering going ESM native in next major instead of dealing with dual builds (especially since there is now the experimental support for require(esm) in both node 20 and 22). It will likely happen later this year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants