Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adopt new version of curl-cffi #543

Merged
merged 3 commits into from
Sep 25, 2024
Merged

fix: adopt new version of curl-cffi #543

merged 3 commits into from
Sep 25, 2024

Conversation

vdusek
Copy link
Collaborator

@vdusek vdusek commented Sep 25, 2024 •
edited
Loading

Description

Issues

  • N/A (ad-hoc fix)

Testing

  • The current set of unit tests should cover the changes.

Checklist

  • CI passed

@vdusek vdusek added bug Something isn't working. t-tooling Issues with this label are in the ownership of the tooling team. adhoc Ad-hoc unplanned task added during the sprint. labels Sep 25, 2024
@vdusek vdusek added this to the 99th sprint - Tooling team milestone Sep 25, 2024
@vdusek vdusek self-assigned this Sep 25, 2024
@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Sep 25, 2024
@vdusek vdusek mentioned this pull request Sep 25, 2024
Draft
1 task
janbuchar
janbuchar approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@janbuchar janbuchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one thing to clarify

src/crawlee/http_clients/curl_impersonate.py Outdated Show resolved Hide resolved
@vdusek vdusek merged commit f6fcf48 into master Sep 25, 2024
19 checks passed
@vdusek vdusek deleted the update-curl-cffi branch September 25, 2024 07:30
@B4nan
Copy link
Member

B4nan commented Sep 25, 2024

lol, so even in python world maintainers don't care about semver :D

@janbuchar
Copy link
Collaborator

janbuchar commented Sep 25, 2024 •
edited
Loading

lol, so even in python world maintainers don't care about semver :D

I don't think this phenomenon is language-specific 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janbuchar janbuchar janbuchar approved these changes

Assignees

@vdusek vdusek

Labels
adhoc Ad-hoc unplanned task added during the sprint. bug Something isn't working. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.
Projects
None yet
Milestone
99th sprint - Tooling team
Development

Successfully merging this pull request may close these issues.
3 participants
@vdusek @B4nan @janbuchar