Render app credential warnings with BigPipe #957
Conversation
|
So this is the first version of the solution and it is subject to changes, especially around wording. The main idea that we would keep the old way until 4.0.0 because downstream projects may (and most probably) customized how app credentials are rendered. Also, if you would wonder, this also works without Big Pipe having enabled, it just renders everything synchronously, so we do not need to make it a requirement - maybe a warning on admin/reports/status page for that would be useful if it is not enabled. |
| @@ -138,6 +139,12 @@ function apigee_edge_theme() { | |||
| 'render element' => 'elements', | |||
| 'base hook' => 'apigee_secret', | |||
| ], | |||
| 'apigee_app_credential_warnings' => [ | |||
There was a problem hiding this comment.
This should superior flexibility for downstream projects to customize these.
| @@ -0,0 +1,5 @@ | |||
| <div class="app-credential-warnings"> | |||
| @@ -0,0 +1,5 @@ | |||
| <div class="app-credential-warnings"> | |||
mxr576
force-pushed
the
app_credential_warnings_bigpipe
branch
from
4ee80ed to
a6c1b79
Compare
| * {@inheritdoc} | ||
| */ | ||
| public static function trustedCallbacks(): array { | ||
| return ['lazyBuilder']; |
There was a problem hiding this comment.
(Why on earth invokable classes are not supported...???!)
|
@divya-intelli @giteshk what is your opinion about the suggested approach? Does this PR worth to be continued? Anything that you would change on the base idea? |
| @@ -66,6 +66,9 @@ apigee_edge.common_app_settings: | |||
| callback_url_placeholder: | |||
| type: label | |||
| label: 'Placeholder for a Callback URL' | |||
| app_credential_warnings_bc_mode: | |||
| type: boolean | |||
| deprecated: "The 'app_credential_warnings_bc_mode' config schema is deprecated in Apigee Edge 3.0.3 and will be removed from Apigee Edge 4.0.0." | |||
There was a problem hiding this comment.
Todo adjust version number before merge.
@mxr576 , its good to have this feature which will speed up the page. |
This solves Problem 1 from #944.