Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds support for GDAC #317 #318

Merged
merged 3 commits into from
Oct 17, 2023
Merged

feat: adds support for GDAC #317 #318

merged 3 commits into from
Oct 17, 2023

Conversation

srinandan
Copy link
Collaborator

No description provided.

@srinandan srinandan added the enhancement New feature or request label Oct 17, 2023
@srinandan srinandan linked an issue Oct 17, 2023 that may be closed by this pull request
allow fetching tokens via google default application credentials #317
Closed
kurtkanaskie
kurtkanaskie approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@kurtkanaskie kurtkanaskie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srinandan srinandan merged commit 22aae90 into main Oct 17, 2023
5 checks passed
@srinandan srinandan deleted the issue317 branch October 17, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurtkanaskie kurtkanaskie kurtkanaskie approved these changes

@ssvaidyanathan ssvaidyanathan Awaiting requested review from ssvaidyanathan

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

allow fetching tokens via google default application credentials
2 participants
@srinandan @kurtkanaskie