Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: fixes null value when app was not found #508 #509

Merged
merged 3 commits into from
Jul 18, 2024
Merged

bug: fixes null value when app was not found #508 #509

merged 3 commits into from
Jul 18, 2024

Conversation

srinandan
Copy link
Collaborator

No description provided.

@srinandan srinandan requested a review from kurtkanaskie July 17, 2024 03:57
@srinandan srinandan linked an issue Jul 17, 2024 that may be closed by this pull request
Odd behavior querying app that does not exist #508
Closed
@srinandan srinandan added the bug Something isn't working label Jul 17, 2024
kurtkanaskie
kurtkanaskie approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@kurtkanaskie kurtkanaskie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - returning the response from the underlying API makes sense.

@srinandan srinandan merged commit d3d63fc into main Jul 18, 2024
4 checks passed
@srinandan srinandan deleted the issue508 branch July 18, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurtkanaskie kurtkanaskie kurtkanaskie approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Odd behavior querying app that does not exist
2 participants
@srinandan @kurtkanaskie