Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: sets safeundeploy default to false #409 #512

Merged
merged 2 commits into from
Jul 18, 2024
Merged

bug: sets safeundeploy default to false #409 #512

merged 2 commits into from
Jul 18, 2024

Conversation

srinandan
Copy link
Collaborator

No description provided.

@srinandan srinandan requested a review from kurtkanaskie July 18, 2024 15:36
@srinandan srinandan linked an issue Jul 18, 2024 that may be closed by this pull request
Copy link
Collaborator

@kurtkanaskie kurtkanaskie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"deployment will proceed if there are no conflicts; default is true"

Needs to be changed to "false"

@srinandan srinandan requested a review from kurtkanaskie July 18, 2024 16:23
Copy link
Collaborator

@kurtkanaskie kurtkanaskie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srinandan srinandan merged commit 0062579 into main Jul 18, 2024
4 checks passed
@srinandan srinandan deleted the issue409 branch July 18, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Api Undeploy issue
2 participants