-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloud Firestore facade reference #701
Conversation
Update of my own remote repo
Refresh token management on the identity-facade reference
PR to push a new reference in devrel (Apigee + Firestore)
20c5e9a
to
1e3c6a6
Compare
1e3c6a6
to
1e16fda
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some minor nitpicks for naming and consistency
...facade/sf-firestore-facade-populate-v1/sharedflowbundle/resources/jsc/JS-PopulateFirebase.js
Outdated
Show resolved
Hide resolved
...facade/sf-firestore-facade-populate-v1/sharedflowbundle/resources/jsc/JS-PopulateFirebase.js
Outdated
Show resolved
Hide resolved
...facade/sf-firestore-facade-populate-v1/sharedflowbundle/resources/jsc/JS-PopulateFirebase.js
Outdated
Show resolved
Hide resolved
...facade/sf-firestore-facade-populate-v1/sharedflowbundle/resources/jsc/JS-PopulateFirebase.js
Outdated
Show resolved
Hide resolved
references/firestore-facade/templates/AM-SetFirestoreMock.template.xml
Outdated
Show resolved
Hide resolved
/gcbrun |
/gcbrun |
Pipeline Report
View details in Cloud Build (permission required) Commit version: a903cbf |
/gcbrun |
Pipeline Report
View details in Cloud Build (permission required) Commit version: a903cbf |
/gcbrun |
Pipeline Report
View details in Cloud Build (permission required) Commit version: a903cbf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
New Apigee reference: Cloud Firestore facade in Apigee X/hybrid
Housekeeping
(please check all that apply [x], do not edit the text)
Full Repo Validation Required
(please check all that apply [x], do not edit the text)
CC: @apigee-devrel-reviewers