Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud Firestore facade reference #701

Merged
merged 10 commits into from
Oct 6, 2023

Conversation

JoelGauci
Copy link
Collaborator

@JoelGauci JoelGauci commented Sep 7, 2023

Description

New Apigee reference: Cloud Firestore facade in Apigee X/hybrid

  • Shared flows acting as a facade in front of a Cloud Firestore db
  • Demo mode to save the API developer from having to create a Cloud Firestore database in Google Cloud

Housekeeping

(please check all that apply [x], do not edit the text)

  • I have run all the tests locally and they all pass.
  • I have followed the relevant style guide for my changes.

Full Repo Validation Required

(please check all that apply [x], do not edit the text)

  • PR requires full pipeline run (Run for changes only by default).

CC: @apigee-devrel-reviewers

Update of my own remote repo
Refresh token management on the identity-facade reference
PR to push a new reference in devrel (Apigee + Firestore)
@OmidTahouri OmidTahouri changed the title Cloud Firestore facada reference in Apigee X/hybrid Cloud Firestore facade reference Sep 7, 2023
@JoelGauci JoelGauci force-pushed the feature/firestore-facade branch from 20c5e9a to 1e3c6a6 Compare September 8, 2023 14:05
@JoelGauci JoelGauci force-pushed the feature/firestore-facade branch from 1e3c6a6 to 1e16fda Compare September 8, 2023 14:16
@OmidTahouri OmidTahouri self-assigned this Oct 5, 2023
Copy link
Collaborator

@OmidTahouri OmidTahouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor nitpicks for naming and consistency

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
references/firestore-facade/.gitignore Outdated Show resolved Hide resolved
references/firestore-facade/README.md Show resolved Hide resolved
references/firestore-facade/README.md Outdated Show resolved Hide resolved
@OmidTahouri
Copy link
Collaborator

/gcbrun

@OmidTahouri
Copy link
Collaborator

/gcbrun

@apigee-devrel-bot
Copy link

Pipeline Report

Pipeline Result Elapsed Wall Time
references/firestore-facade fail 4s
TOTAL PIPELINE pass 4s

View details in Cloud Build (permission required)

Commit version: a903cbf

@OmidTahouri
Copy link
Collaborator

/gcbrun

@apigee-devrel-bot
Copy link

Pipeline Report

Pipeline Result Elapsed Wall Time
references/firestore-facade pass 243s
TOTAL PIPELINE pass 243s

View details in Cloud Build (permission required)

Commit version: a903cbf

@JoelGauci
Copy link
Collaborator Author

/gcbrun

@apigee-devrel-bot
Copy link

Pipeline Report

Pipeline Result Elapsed Wall Time
references/firestore-facade pass 218s
TOTAL PIPELINE pass 218s

View details in Cloud Build (permission required)

Commit version: a903cbf

Copy link
Collaborator

@OmidTahouri OmidTahouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OmidTahouri OmidTahouri merged commit 79f1fb0 into apigee:main Oct 6, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants