-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix export.sh #705
Fix export.sh #705
Conversation
Fix issue curl: (3) URL rejected: Malformed input to a URL function
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hi @Chris7X -- many thanks for the fix! A couple of things to help move this forward:
Out of curiousity, could you share which whitespace character was tripping you up and, if known, how the resource might have been created with that name (UI/API)? Thanks! |
@@ -51,8 +51,9 @@ loginfo "exporting to $export_folder" | |||
mkdir -p "$export_folder" | |||
|
|||
sackmesser list "organizations/$organization/sharedflows" | jq -r -c '.[]|. | select((. | length) > 1)' | while read -r sharedflow; do | |||
# Replacing white Spaces in the sharedflow name with %20 | |||
# Replacing white Spaces in the sharedflow name with %20, then removes special characters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick, to be more accurate: "removes whitespace characters"
@@ -62,8 +63,9 @@ sackmesser list "organizations/$organization/sharedflows" | jq -r -c '.[]|. | se | |||
done | |||
|
|||
sackmesser list "organizations/$organization/apis" | jq -r -c '.[]|.' | while read -r proxy; do | |||
# Replacing white Spaces in the proxy name with %20 | |||
# Replacing white Spaces in the proxy name with %20, then removes special characters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick, to be more accurate: "removes whitespace characters"
/gcbrun |
Pipeline Report
View details in Cloud Build (permission required) Commit version: c2318db |
Closing due to inactivity |
Description
What's changed, or what was fixed?
\r
), newline (\n
), and tab (\t
) from the URL.Issues Fixed
Housekeeping
(please check all that apply [x], do not edit the text)
Full Repo Validation Required
(please check all that apply [x], do not edit the text)
CC: @apigee-devrel-reviewers