Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gcp sa flow key cleanup #734

Merged
merged 1 commit into from
May 3, 2024
Merged

fix: gcp sa flow key cleanup #734

merged 1 commit into from
May 3, 2024

Conversation

danistrebel
Copy link
Collaborator

Description

What's changed, or what was fixed?

  • clean up the existing service account keys earlier in the pipeline so that service account keys don't pile up if the pipeline breaks repeatedly

Issues Fixed

Housekeeping

(please check all that apply [x], do not edit the text)

  • I have run all the tests locally and they all pass.
  • I have followed the relevant style guide for my changes.

Full Repo Validation Required

(please check all that apply [x], do not edit the text)

  • PR requires full pipeline run (Run for changes only by default).

CC: @apigee-devrel-reviewers

@danistrebel
Copy link
Collaborator Author

/gcbrun

Copy link
Collaborator

@OmidTahouri OmidTahouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented May 3, 2024

Mega-Linter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 4 0 0.14s
⚠️ BASH bash-exec 102 1 12.9s
✅ BASH shellcheck 102 0 16.75s
⚠️ BASH shfmt 102 90 13.35s
⚠️ COPYPASTE jscpd yes 53 5.9s
✅ CREDENTIALS secretlint yes no 4.08s
✅ DOCKERFILE dockerfilelint 8 0 3.05s
✅ DOCKERFILE hadolint 8 0 2.03s
✅ GIT git_diff yes no 0.11s
✅ JAVA checkstyle 6 0 11.15s
✅ JAVASCRIPT eslint 91 0 1.89s
✅ JSON eslint-plugin-jsonc 62 0 6.73s
✅ JSON jsonlint 62 0 28.77s
⚠️ JSON prettier 62 1 5.51s
✅ JSON v8r 62 0 282.07s
⚠️ MARKDOWN markdownlint 49 134 1.08s
✅ MARKDOWN markdown-link-check 49 0 110.95s
⚠️ MARKDOWN markdown-table-formatter 49 1 0.43s
✅ OPENAPI spectral 11 0 31.67s
✅ PYTHON bandit 7 0 1.38s
⚠️ PYTHON black 7 1 1.95s
✅ PYTHON flake8 7 0 1.24s
⚠️ PYTHON isort 7 7 0.49s
⚠️ PYTHON mypy 7 1 0.47s
✅ PYTHON pylint 7 0 7.91s
⚠️ SPELL cspell 795 1316 38.15s
⚠️ SPELL misspell 795 1 0.43s
✅ XML xmllint 402 0 0.18s
⚠️ YAML prettier 33 1 2.87s
✅ YAML v8r 33 0 99.41s
✅ YAML yamllint 33 0 1.03s

See errors details in artifact Mega-Linter reports on GitHub Action page

You could have same capabilities but better runtime performances if you request a new Mega-Linter flavor.

@apigee-devrel-bot
Copy link

Pipeline Report

Pipeline Result Elapsed Wall Time
references/gcp-sa-auth-shared-flow pass 212s
TOTAL PIPELINE pass 212s

View details in Cloud Build (permission required)

Commit version: 1d000aa

@danistrebel danistrebel merged commit e7cb320 into main May 3, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly build failure
3 participants