Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connection.ActiveConfig() should use config.Active() instead of reading configuration directly #1232

Merged
merged 3 commits into from
Oct 16, 2023

Add tests for config.ReadValid()

94e5690
Select commit
Loading
Failed to load commit list.
Merged

connection.ActiveConfig() should use config.Active() instead of reading configuration directly #1232

Add tests for config.ReadValid()
94e5690
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Oct 13, 2023 in 1s

71.91% (-0.07%) compared to f805290

View this Pull Request on Codecov

71.91% (-0.07%) compared to f805290

Details

Codecov Report

Merging #1232 (94e5690) into main (f805290) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1232      +/-   ##
==========================================
- Coverage   71.98%   71.91%   -0.07%     
==========================================
  Files         146      146              
  Lines       12241    12250       +9     
==========================================
- Hits         8812     8810       -2     
- Misses       2747     2759      +12     
+ Partials      682      681       -1     
Files Coverage Δ
pkg/config/config.go 60.49% <100.00%> (+0.74%) ⬆️
pkg/connection/config.go 47.05% <100.00%> (-17.39%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more