Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #26
See https://guides.rubyonrails.org/upgrading_ruby_on_rails.html for helpful guide on 7.0 -> 7.1 updating
Not sure what's causing it, but I'm getting mysterious new
shm
andwal
sqlite files when thebin/setup
runs. Similar to what this person reported happening (but without a clear resolution): https://discuss.rubyonrails.org/t/new-temp-files-for-sqlite3-shm-wal/83837I resolved that on the big commit: e553666; I believe it had to do with changes to the
bin/setup
file. Seems to work fine now.Getting some deprecation warnings apparently from Devise that are a known (still unfixed) issue:
heartcombo/devise#5644
I fixed this, per the suggestion on that issue, on the commit: f07607e
Edit:☹️ well that doesn't work because as soon as one runs
rails generate devise:install
and overwrites the included initializer, the deprecation warnings come back.. It does work though if I just give the little patch a different name: 1992701. A bit awkward but don't see another work around until they make an official fix to the gemEverything seems to work when I:
rails generate devise:install
rspec
rails console
bin/server
live previewTODO: For final testing, create a branch of e.g. Photogram Final and try to use this PR as a base template to see if everything keeps working as expected.
Additional testing done in: https://github.com/matchthetarget/photogram-final-rails-7-2-test