Upgrade to Rails 7.1 (Scratch) #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpurinton
commented
May 29, 2024
| @@ -3,7 +3,7 @@ | |||
| { | |||
| "name": "Container", | |||
| // Or use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile | |||
| "image": "firstdraft/appdev-rails-template", | |||
| "image": "firstdraft/appdev-rails-template-for-testing", | |||
There was a problem hiding this comment.
TODO; remove / replace the original image when done testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #26
See https://guides.rubyonrails.org/upgrading_ruby_on_rails.html for helpful guide on 7.0 -> 7.1 updating
Not sure what's causing it, but I'm getting mysterious new
shmandwalsqlite files when thebin/setupruns. Similar to what this person reported happening (but without a clear resolution): https://discuss.rubyonrails.org/t/new-temp-files-for-sqlite3-shm-wal/83837I resolved that on the big commit: e553666; I believe it had to do with changes to the
bin/setupfile. Seems to work fine now.Getting some deprecation warnings apparently from Devise that are a known (still unfixed) issue:
heartcombo/devise#5644
I fixed this, per the suggestion on that issue, on the commit: f07607e
Edit:☹️ well that doesn't work because as soon as one runs
rails generate devise:installand overwrites the included initializer, the deprecation warnings come back.. It does work though if I just give the little patch a different name: 1992701. A bit awkward but don't see another work around until they make an official fix to the gemEverything seems to work when I:
rails generate devise:installrspecrails consolebin/serverlive previewTODO: For final testing, create a branch of e.g. Photogram Final and try to use this PR as a base template to see if everything keeps working as expected.
Additional testing done in: https://github.com/matchthetarget/photogram-final-rails-7-2-test