Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 - Deprecated FCM APIs, add FCM method (HTTP v1 new API) #207

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

wcalebgray
Copy link
Contributor

From PR #194 , this copies over the code and fixes the tests (mostly ramda failing)

Exactly none of this has been tested so far.

@wcalebgray wcalebgray changed the title re-do PR from original repo and fix tests V2 - Deprecated FCM APIs, add FCM method (HTTP v1 new API) Jun 18, 2024
@giantslogik
Copy link

@wcalebgray there an ETA on this or a linked issue?

@alex-friedl
Copy link
Collaborator

@wcalebgray @giantslogik If you can confirm that this PR version works with FCM, I'd be happy to take a closer look and merge and release it

@giantslogik
Copy link

@alex-friedl @wcalebgray I'll try and test the PR for my usecase. I've also created #208 to keep users informed of the issue / resolution.

@wcalebgray
Copy link
Contributor Author

I've tested this manually and it appears to work for FCM, but I have not completely tested all other uses to make sure nothing else broke. Would very much welcome other testing.

@alex-friedl
Copy link
Collaborator

Merging this in order to fix linter and doc issues and prepare a release

@alex-friedl alex-friedl merged commit bf48278 into appfeel:master Jun 19, 2024
0 of 4 checks passed
@giantslogik
Copy link

@alex-friedl how are the typescript definitions maintained ? I'm using @types/node-pushnotifications , and don't see the FCM API there.
cc: @wcalebgray

@alex-friedl
Copy link
Collaborator

They are maintained separately in that package, yes. However I am not maintaining these. I assume they will catch up eventually but feel free to make a PR there, it would be greatly appreciated :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants