chore: Bump chai and chai-as-promised (#387)

* chore: Bump chai and chai-as-promised

* fix lint

.github/workflows/unit-test.yml

@@ -6,11 +6,11 @@ jobs:
   prepare_matrix:
     runs-on: ubuntu-latest
     outputs:
-      versions: ${{ steps.generate-matrix.outputs.versions }}
+      versions: ${{ steps.generate-matrix.outputs.active }}
     steps:
-    - name: Select 3 most recent LTS versions of Node.js
+    - name: Select all active LTS versions of Node.js
       id: generate-matrix
-      run: echo "versions=$(curl -s https://endoflife.date/api/nodejs.json | jq -c '[[.[] | select(.lts != false)][:3] | .[].cycle | tonumber]')" >> "$GITHUB_OUTPUT"
+      uses: msimerson/node-lts-versions@v1
 
 
   test:

package.json

@@ -73,17 +73,13 @@
     "@semantic-release/changelog": "^6.0.1",
     "@semantic-release/git": "^10.0.1",
     "@types/bluebird": "^3.5.38",
-    "@types/chai": "^4.3.5",
-    "@types/chai-as-promised": "^7.1.5",
     "@types/lodash": "^4.14.196",
     "@types/mocha": "^10.0.1",
     "@types/node": "^20.4.7",
-    "@types/sinon": "^17.0.0",
-    "@types/sinon-chai": "^3.2.9",
     "@types/teen_process": "^2.0.0",
     "appium-ios-simulator": "^6.1.2",
-    "chai": "^4.1.2",
-    "chai-as-promised": "^7.1.1",
+    "chai": "^5.1.1",
+    "chai-as-promised": "^8.0.0",
     "conventional-changelog-conventionalcommits": "^8.0.0",
     "mocha": "^10.0.0",
     "mocha-junit-reporter": "^2.0.0",

test/functional/safari-e2e-specs.js

@@ -3,15 +3,9 @@ import { getSimulator } from 'appium-ios-simulator';
 import { retryInterval, retry } from 'asyncbox';
 import { util } from '@appium/support';
 import _ from 'lodash';
-import chai from 'chai';
-import chaiAsPromised from 'chai-as-promised';
 import { createRemoteDebugger } from '../../index';
 import { startHttpServer, stopHttpServer } from './http-server';
 
-
-chai.should();
-chai.use(chaiAsPromised);
-
 const SIM_NAME = process.env.SIM_DEVICE_NAME || `appium-test-${util.uuidV4()}`;
 const DEVICE_NAME = process.env.DEVICE_NAME || 'iPhone 15';
 const PLATFORM_VERSION = process.env.PLATFORM_VERSION || '17.2';
@@ -41,10 +35,16 @@ describe('Safari remote debugger', function () {
   this.timeout(480000);
   this.retries(2);
 
+  let chai;
   let sim;
   let simCreated = false;
   let address;
   before(async function () {
+    chai = await import('chai');
+    const chaiAsPromised = await import('chai-as-promised');
+    chai.should();
+    chai.use(chaiAsPromised.default);
+
     sim = await getExistingSim(DEVICE_NAME, PLATFORM_VERSION);
     if (!sim) {
       const udid = await new Simctl().createDevice(SIM_NAME, DEVICE_NAME, PLATFORM_VERSION);

test/unit/mixins/execute-specs.js

@@ -1,17 +1,19 @@
-import chai from 'chai';
-import chaiAsPromised from 'chai-as-promised';
 import { MOCHA_TIMEOUT } from '../../helpers/helpers';
 import exec from '../../../lib/mixins/execute';
 import sinon from 'sinon';
 
 const { executeAtom, executeAtomAsync, callFunction, execute } = exec;
 
-chai.should();
-chai.use(chaiAsPromised);
-
 describe('execute', function () {
   this.timeout(MOCHA_TIMEOUT);
 
+  let chai;
+
+  before(async function () {
+    chai = await import('chai');
+    chai.should();
+  });
+
   describe('executeAtom', function () {
     it('should execute atom and call send event on rpc client', async function () {
       const ctx = {

test/unit/mixins/navigate-specs.js

@@ -1,11 +1,13 @@
-import chai from 'chai';
-import chaiAsPromised from 'chai-as-promised';
 import RemoteDebugger from '../../../lib/remote-debugger';
 
-chai.should();
-chai.use(chaiAsPromised);
-
 describe('navigate', function () {
+  let chai;
+
+  before(async function () {
+    chai = await import('chai');
+    chai.should();
+  });
+
   describe('isPageLoadingCompleted', function () {
     const BUNDLE_ID = 'com.apple.mobilesafari';
 

test/unit/remote-messages-specs.js

@@ -1,15 +1,17 @@
 import RemoteMessages from '../../lib/rpc/remote-messages';
-import chai from 'chai';
 import { MOCHA_TIMEOUT } from '../helpers/helpers';
 
-
-chai.should();
-
 describe('RemoteMessages', function () {
   this.timeout(MOCHA_TIMEOUT);
 
+  let chai;
   const remoteMessages = new RemoteMessages();
 
+  before(async function () {
+    chai = await import('chai');
+    chai.should();
+  });
+
   describe('getRemoteCommand', function () {
     const commands = [
       'setConnectionKey', 'connectToApp', 'setSenderKey', 'indicateWebView',

test/unit/rpc/rpc-client-specs.js

@@ -1,15 +1,19 @@
-import chai from 'chai';
-import chaiAsPromised from 'chai-as-promised';
 import sinon from 'sinon';
 import { MOCHA_TIMEOUT } from '../../helpers/helpers';
 import RpcClient from '../../../lib/rpc/rpc-client';
 
-chai.should();
-chai.use(chaiAsPromised);
-
 describe('rpc-client', function () {
   this.timeout(MOCHA_TIMEOUT);
 
+  let chai;
+
+  before(async function () {
+    chai = await import('chai');
+    const chaiAsPromised = await import('chai-as-promised');
+    chai.should();
+    chai.use(chaiAsPromised.default);
+  });
+
   describe('.send', function () {
     it('should send RPC message to device', async function () {
     });

test/unit/utils-specs.js

@@ -1,18 +1,21 @@
 import {
   pageArrayFromDict, checkParams, appInfoFromDict, getDebuggerAppKey, getPossibleDebuggerAppKeys
 } from '../../lib/utils';
-import chai from 'chai';
-import chaiAsPromised from 'chai-as-promised';
 import _ from 'lodash';
 import { MOCHA_TIMEOUT } from '../helpers/helpers';
 
-
-const expect = chai.expect;
-chai.should();
-chai.use(chaiAsPromised);
-
 describe('utils', function () {
   this.timeout(MOCHA_TIMEOUT);
+  let chai;
+  let expect;
+
+  before(async function () {
+    chai = await import('chai');
+    const chaiAsPromised = await import('chai-as-promised');
+    chai.should();
+    chai.use(chaiAsPromised.default);
+    expect = chai.expect;
+  });
 
   describe('appInfoFromDict', function () {
     it('should return the id and entry for a dict', function () {