Skip to content

Commit

Permalink
feat!: Update selenium dependency to 4.12 (#908)
Browse files Browse the repository at this point in the history
BREAKING CHANGE: The minimum supported Python version set to 3.8
BREAKING CHANGE: The minimum supported selenium version set to 4.12
  • Loading branch information
mykola-mokhnach authored Sep 1, 2023
1 parent d5b84b8 commit 2e49569
Show file tree
Hide file tree
Showing 11 changed files with 11 additions and 46 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/unit-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ["3.7", "3.8", "3.9", "3.10", "3.11"]
python-version: ["3.8", "3.9", "3.10", "3.11"]
steps:
- uses: actions/checkout@v3
- name: Set up Python ${{ matrix.python-version }}
Expand Down
3 changes: 1 addition & 2 deletions Pipfile
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@ pytest = "~=7.4"
pytest-cov = "~=4.1"
python-dateutil = "~=2.8"
tox = "~=4.8"
typing-extensions = "~=4.7"
types-python-dateutil = "~=2.8"

[packages]
selenium = "~=4.11"
selenium = "~=4.12"
4 changes: 1 addition & 3 deletions appium/options/common/supports_capabilities.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,7 @@
# specific language governing permissions and limitations
# under the License.

from typing import Any, TypeVar

from appium.protocols.protocol import Protocol
from typing import Any, Protocol, TypeVar

T = TypeVar('T')

Expand Down
22 changes: 0 additions & 22 deletions appium/protocols/protocol.py

This file was deleted.

4 changes: 1 addition & 3 deletions appium/protocols/webdriver/can_execute_commands.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,10 @@
# See the License for the specific language governing permissions and
# limitations under the License.

from typing import Dict, Union
from typing import Dict, Protocol, Union

from selenium.webdriver.remote.remote_connection import RemoteConnection

from ..protocol import Protocol


class CanExecuteCommands(Protocol):
command_executor: RemoteConnection
Expand Down
4 changes: 1 addition & 3 deletions appium/protocols/webdriver/can_execute_scripts.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

from typing import Any, List, Optional

from ..protocol import Protocol
from typing import Any, List, Optional, Protocol


class CanExecuteScripts(Protocol):
Expand Down
4 changes: 1 addition & 3 deletions appium/protocols/webdriver/can_find_elements.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

from typing import TYPE_CHECKING, Dict, List, Union

from ..protocol import Protocol
from typing import TYPE_CHECKING, Dict, List, Protocol, Union

if TYPE_CHECKING:
from appium.webdriver.webelement import WebElement
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

from typing import TypeVar

from ..protocol import Protocol
from typing import Protocol, TypeVar

T = TypeVar('T')

Expand Down
3 changes: 1 addition & 2 deletions appium/webdriver/switch_to.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,10 @@
# See the License for the specific language governing permissions and
# limitations under the License.

from typing import TYPE_CHECKING, Optional, cast
from typing import TYPE_CHECKING, Optional, Protocol, cast

from selenium.webdriver.remote.switch_to import SwitchTo

from appium.protocols.protocol import Protocol
from appium.protocols.webdriver.can_execute_commands import CanExecuteCommands

from .mobilecommand import MobileCommand
Expand Down
3 changes: 1 addition & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
classifiers=[
'Development Status :: 5 - Production/Stable',
'Programming Language :: Python',
'Programming Language :: Python :: 3.7',
'Programming Language :: Python :: 3.8',
'Programming Language :: Python :: 3.9',
'Programming Language :: Python :: 3.10',
Expand All @@ -50,5 +49,5 @@
'Topic :: Software Development :: Quality Assurance',
'Topic :: Software Development :: Testing',
],
install_requires=['selenium ~= 4.1'],
install_requires=['selenium ~= 4.12'],
)
4 changes: 2 additions & 2 deletions tox.ini
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
[tox]
skipsdist = True
envlist =
py37,
py38,
py39
py39,
py311

[testenv]
deps =
Expand Down

0 comments on commit 2e49569

Please sign in to comment.