-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: cleanup functional tests and move to unit test to CI stable #1024
Conversation
def set_capability(self: T, name: str, value: Any) -> T: | ||
... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are by https://github.com/appium/python-client/blob/master/.pre-commit-config.yaml
Let's see how CI will be...
Hm, maybe we should update the commit hook config. Moving to draft for now. |
httpretty.register_uri(httpretty.POST, appium_command('/session/1234567890/execute/sync'), body='{"value": ""}') | ||
result = driver.install_app('path/to/app') | ||
|
||
assert {'app': 'path/to/app'}, get_httpretty_request_body(httpretty.last_request()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like this test's assertion was wrong. I'm fixing this kind of error as well as part of https://github.com/appium/python-client/issues
test/unit/webdriver/context_test.py
Outdated
|
||
driver.switch_to.context('NATIVE_APP') | ||
|
||
assert {'name': 'NATIVE_APP'}, get_httpretty_request_body(httpretty.last_request()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assertion is wrong. I think you missed ==
test/unit/webdriver/context_test.py
Outdated
|
||
driver.switch_to.context(None) | ||
|
||
assert {'name': None}, get_httpretty_request_body(httpretty.last_request()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part of #1023 . It looks like... the amount of change (including test fixes) will gain, so let me split PRs.