-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: remove several previously deprecated APIs #909
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
""" | ||
warnings.warn( | ||
'The "available_ime_engines" API is deprecated and will be removed in future versions. ' | ||
'Use "mobile: shell" extension instead', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add mobile
command for IME handling? Because mobile:shell
is behind a security flag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not see any people using these so far as these APIs are very specific.
Eventually they could be called anyway using adb shell extension
Why is set_value removed? How can I set a slider value now? |
BREAKING CHANGE: Removed obsolete all_sessions and session properties
BREAKING CHANGE: Removed the obsolete start_activity method
BREAKING CHANGE: Removed the obsolete end_test_coverage method
BREAKING CHANGE: Removed the following obsolete arguments from the driver constructor: desired_capabilities, browser_profile, proxy
BREAKING CHANGE: Removed obsolete set_value and set_text methods
BREAKING CHANGE: Removed the obsolete MobileBy class
BREAKING CHANGE: Removed obsolete application management methods: launch_app, close_app, reset
BREAKING CHANGE: Removed obsolete IME methods: available_ime_engines, is_ime_active, activate_ime_engine, deactivate_ime_engine, active_ime_engine