ci: use gha instead of Azure for iOS in Azure #987
Conversation
| @@ -43,21 +47,29 @@ jobs: | |||
| model: 'iPhone 15 Plus' | |||
| os_version: '17.4' | |||
There was a problem hiding this comment.
It makes sense to extract these values and keep them in a single place, for example env variables
The reason for it is that when we need to change iOS version this also usually requires to change phone model and macOS version
There was a problem hiding this comment.
Yes, similar thing will occur in Android as well, I believe. So firsly I move Azure to GHA without such definition and will do for Android and iOS both later. Then perhaps it would make sense to modify python code side as well to refer to them.
| @@ -28,7 +28,7 @@ def get_desired_capabilities(app: Optional[str] = None) -> Dict[str, Any]: | |||
| desired_caps: Dict[str, Any] = { | |||
| 'deviceName': iphone_device_name(), | |||
| 'platformName': 'iOS', | |||
| 'platformVersion': '15.5', | |||
| 'platformVersion': '17.4', | |||
There was a problem hiding this comment.
this value should be received from CI env
| @@ -28,7 +28,7 @@ def get_desired_capabilities(app: Optional[str] = None) -> Dict[str, Any]: | |||
| desired_caps: Dict[str, Any] = { | |||
| 'deviceName': iphone_device_name(), | |||
There was a problem hiding this comment.
this value should be received from CI env
| @@ -70,7 +70,7 @@ def wda_port() -> int: | |||
|
|
|||
|
|
|||
| def iphone_device_name() -> str: | |||
| prefix = 'iPhone 12' | |||
| prefix = 'iPhone 15 Plus' | |||
There was a problem hiding this comment.
this value should be received from CI env
| @@ -18,14 +18,14 @@ | |||
|
|
|||
| class TestFindByElementWebelement(BaseTestCase): | |||
| def test_find_element_by_path(self) -> None: | |||
| el = self.driver.find_element(by=AppiumBy.IOS_PREDICATE, value='wdName == "UICatalog"') | |||
| assert 'UICatalog' == el.get_attribute('name') | |||
| el = self.driver.find_element(by=AppiumBy.IOS_PREDICATE, value='wdName == "UIKitCatalog"') | |||
There was a problem hiding this comment.
should the constant also be used in the locator? same below
functional-test.yml can optimize more, but for now, this PR aims to drop Azure tests for iOS.
I'll update functional-test.yml for GHA after adding Android to remove azure.