Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: non-app capability handling #1039

Merged
merged 3 commits into from
Aug 6, 2024
+5 −2
Merged

fix: non-app capability handling #1039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf3aa4d
fix: skip absolute_app_path for non-app
KazuCocoa Aug 6, 2024
bc2842b
update changelog
KazuCocoa Aug 6, 2024
820e0af
tweak the order
KazuCocoa Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ Commit based release not is [release_notes.md](./release_notes.md)

Release tags are https://github.com/appium/ruby_lib/releases .

## not released
- Fix non `app` capability behavior

## 15.2.1 - 2024-08-03
- Fix client side timeout in the default http client
- Bump appium_lib_core 9.2.1+ to apply the fix
Expand Down
4 changes: 2 additions & 2 deletions lib/appium_lib/driver.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,9 +269,9 @@ def set_app_path(opts)

# return the path exists on the local
app_path = Driver.get_cap(@core.caps, 'app')
return if !app_path.nil? && File.exist?(app_path)
return if app_path.nil?
return if File.exist?(app_path)

# The app file is not exact path
@core.caps['app'] = self.class.absolute_app_path opts
end

Expand Down
Loading