Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restore test_apply_paddings_check runtime_checks test #771

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

restore test_apply_paddings_check runtime_checks test #771

wants to merge 2 commits into from

Commits on Oct 22, 2024

  1. restore test_apply_paddings_check runtime_checks test 

    The main idea is that we need to call `jax.effects_barrier()`, because the
error may be raised in an XLA computation that is asynchronous with the main
Python thread and therefore we need to block. (There may have been a recent
change in behavior, where JAX runs more computations asynchronously on the CPU
backend.) We could put that call to `jax.effects_barrier()` in the test code
(and corresponding user code), or we could bulid it into the `runtime_checks`
context manager.  Currently this commit does the latter.

I also tweaked the `runtime_checks` logic to use a `try/finally` pattern to
restore the state when the context is exited, even when it's exited via
exception. We may want to do the same to context managers like
`numeric_checks`.

While the test now passes, there is a gross warning printed about "Exception
ignored in atexit callback". That may be a JAX internal bug, or it may be some
quirk of CPython 3.10; I haven't investigated further. Let me know if that
seems like a problem.
    @mattjj
    mattjj committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    d403281 View commit details
    Browse the repository at this point in the history

  2. use JaxRuntimeError name when available

    @mattjj
    mattjj committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    36a938c View commit details
    Browse the repository at this point in the history